https://bugzilla.redhat.com/show_bug.cgi?id=1113301
Miroslav Suchý <msuchy(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |msuchy(a)redhat.com
Assignee|nobody(a)fedoraproject.org |msuchy(a)redhat.com
--- Comment #4 from Miroslav Suchý <msuchy(a)redhat.com> ---
Taking.
It would be nice if you can talk to upstream and migrate this tool to use
python3 on Fedora22 (and replace shebang by sed in nova-install during %build
phase if 0%{fedora} >= 22 ).
You should provide man page:
http://fedoraproject.org/wiki/Packaging:Guidelines#Man_pages
You should use:
CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py install -O1 --root=%{buildroot}
--skip-build
instead of direct use -O1.
You should mark license as:
%license COPYING
Description must end by dot.
It would be nice, if you can add tests as SOURCE1 and run them in %check phase.
This
Requires(post): chkconfig
Requires(preun): chkconfig
is IMO not needed and I fail to find any reference to chkconfig in code.
You are missing BR of -devel package:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component