https://bugzilla.redhat.com/show_bug.cgi?id=1795399
--- Comment #1 from dan.cermak(a)cgc-instruments.com ---
A few comments:
- the license is wrong, the package is licensed under the GPLv3.
- there's no need to pass `-p1` to %autosetup, when no patches are added
- Is it necessary to pass `-Dversion=v%{version}` to meson? If I understand the
meson.build correctly, then it should use the correct value by itself.
- Please pass a static url (preferably to the specific git commit) to the *raw*
spec file (i.e. no html), so that fedora-review can use the spec. Here the url
to the spec would be:
https://raw.githubusercontent.com/gicmo/spec/99d9488ddd345e2fc2dba598d02a...
Otherwise it looks good to me, I still need to give it a try though.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component