https://bugzilla.redhat.com/show_bug.cgi?id=2021032
Troy Dawson <tdawson(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tdawson(a)redhat.com
--- Comment #7 from Troy Dawson <tdawson(a)redhat.com> ---
There are three things that need fixing and I'll pass it.
1 - License - You don't have the license files, and there are more licenses
than just 1
2 - Static binary - It's ok where it is, but you need to put a Provides: in the
devel section.
3 - Missing dir's - There are two directories that this package should own.
%{_kf5_qmldir}/org/kde/telephony
%{_includedir}/KF5/kTelephonyMetaTypes
Here is a spec file diff that shows what would be a great fix for all three.
--- plasma-dialer.spec 2022-08-30 23:08:56.000000000 -0700
+++ plasma-dialer.fixed.spec 2022-09-01 11:04:20.415899256 -0700
@@ -3,7 +3,7 @@
Name: plasma-dialer
Version: 22.06
Release: 1%{?dist}
-License: GPLv3
+License: BSD and CC0 and GPLv2 and GPLv2+ and GPLv3 and GPLv3+ and
LGPLv2+ and LGPLv2.1 and LGPLv2.1+ and LGPLv3 and LGPLv3
Summary: Convergent Plasma Mobile dialer application
Url:
https://invent.kde.org/plasma-mobile/plasma-dialer
Source0:
https://download.kde.org/stable/plasma-mobile/%{version}/%{name}-%{versio...
@@ -68,6 +68,7 @@
%description devel
The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.
+Provides: %{name}-static = %{version}-%{release}
%prep
%autosetup -n plasma-dialer-%{version}
@@ -86,6 +87,7 @@
%files -f %{name}.lang
+%license LICENSES/*
%{_kf5_bindir}/plasmaphonedialer
%{_kf5_metainfodir}/%{kde_name}.appdata.xml
@@ -98,13 +100,12 @@
%{_kf5_datadir}/dbus-1/interfaces/org.kde.telephony.*
%{_kf5_datadir}/dbus-1/services/org.kde.telephony.service
%{_kf5_datadir}/dbus-1/services/org.kde.modemdaemon.service
-%{_kf5_qmldir}/org/kde/telephony/libKTelephonyPluginDeclarative.so
-%{_kf5_qmldir}/org/kde/telephony/qmldir
+%{_kf5_qmldir}/org/kde/telephony
%{_libexecdir}/kde-telephony-daemon
%{_libexecdir}/modem-daemon
%files devel
-%{_includedir}/KF5/kTelephonyMetaTypes/dialer-types.h
+%{_includedir}/KF5/kTelephonyMetaTypes
%{_kf5_libdir}/libktelephonymetatypes.a
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2021032