https://bugzilla.redhat.com/show_bug.cgi?id=1176307
--- Comment #2 from Ivan Romanov <drizt(a)land.ru> ---
(In reply to Raphael Groner from comment #1)
Hi Ivan,
there are some hints for your spec file. Please fix those, then I can
continue with the review.
* Use macros whereever possible. Don't use a slash at the end of the URL.
You can use just 'sf' as abbreviation 'sourceforge'.
- URL:
http://sourceforge.net/projects/torrent-file-editor/
+ URL:
http://sf.net/projects/%{name} Fixed.
It's not correct.
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL...
* MUST 'Require: hicolor-icon-theme' cause of the folder
ownership.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
Guidelines#File_and_Directory_Ownership
> %files
> …
> %{_datadir}/icons/hicolor/*/apps/%{name}.png
Fixed.
* SHOULD tell us more about your package in %description. Consider to
write
about the features as mentioned so at the sourceforge page.
Fixed.
* SHOULD directly get the source tarball from github without using
sourceforge
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/
SourceURL#Github
It's not correct.
If the upstream does create tarballs you should use them as tarballs
provide an easier trail for people auditing the packages.
In this case upstream
creates tarballs. So I use them.
* Additional question: Why do you not use Qt5 also in Fedora, like
you do
for the tree product? Fedora 21 has Qt5 packages.
Qt4 now is main. Qt5 only for
development as I understand. Anyway Qt5 variant
looks ugly. I don't want to use it. When Qt5 become stable I will transtition
to it.
Spec URL:
https://raw.githubusercontent.com/drizt/torrent-file-editor-package/717d1...
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/8973/8448973/torrent-file-...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component