https://bugzilla.redhat.com/show_bug.cgi?id=1323214
Ralf Senderek <fedora(a)senderek.ie> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora(a)senderek.ie
--- Comment #1 from Ralf Senderek <fedora(a)senderek.ie> ---
These are my preliminary thoughts about your spec file:
1) Please add a meaningful description that does not only repeat the summary.
People should be able to decide whether or not they'd need to install this
package
2) You need a %changelog entry, please provide such an entry at the end of
your spec file, and keep it up-to-date
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
3) Please specify the upstream URL in Source0, not only the name of the file.
4) Your spec file does not mention Requires:, but from the summary I'd expect
that both git and gpg/gpg2 would be needed at runtime.
5) store your COPYING file under %(_datadir)/licenses/%(name) and tag it as
%license
6) The Group-tag is missing. Also it's optional, it would be nice to place your
binary in a group.
7) Please create a man page for your binary.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component