https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Colin Macdonald <cbm(a)m.fsf.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Petr Šabata <psabata(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1161126 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1161126 [Bug 1161126] Review Request: perl-Config-AutoConf - A module to implement some of AutoConf macros in pure perl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Colin Macdonald <cbm(a)m.fsf.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1165637, 1165639, 1165641 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1165637 [Bug 1165637] Review Request: perl-Business-ISSN - Perl extension for International Standard Serial Numbers https://bugzilla.redhat.com/show_bug.cgi?id=1165639 [Bug 1165639] Review Request: perl-Business-ISMN - perl extension to work with International Standard Music Numbers https://bugzilla.redhat.com/show_bug.cgi?id=1165641 [Bug 1165641] Review Request: perl-Text-BibTeX - Interface to read and parse BibTeX files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #1 from Colin Macdonald <cbm(a)m.fsf.org&gt; --- Question: am I specifying the dependency on texlive-bibtex correctly? The current version in F21 is "4:svn32245.2.8a". I want to specify that biber should not be used with versions less than 2.8. So I put: Requires: texlive-biblatex >= 4:svn32245.2.8 Is that right? What if it compares based on the epoch or svn numbers intead? Presumably the svn number would not increase while the version number went down :) But still, is there a "proper" way to specify its the 2.8 I care about? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #3 from Colin Macdonald <cbm(a)m.fsf.org&gt; --- Updated: https://raw.githubusercontent.com/cbm755/fedora-spec/master/biber.spec http://people.maths.ox.ac.uk/macdonald/fedora/biber-1.8-4.fc21.src.rpm 1. @psabata: What should I do about this? It seems to work without. And AFAICT, Unicode::Collate is baked-in to our perl (?) The META.json file also says this. 2. I may need to fix-up Source0. IIRC (months ago) I followed some guide on packaging from git and re-zipped it as "plk-biber-v1.8-0-g848ca84.zip". But surely I can just use "biber-848ca84face08bdba8a6e8d95447b0ec71e56804.zip", as served by "https://github.com/plk/biber/archive/848ca84face08bdba8a6e8d95447b0ec71e56804.zip"? 3. Actually, on re-reading that, I should probably just take "http://sourceforge.net/projects/biblatex-biber/files/biblatex-biber/1.8/biblatex-biber.tar.gz" instead. Although this filename is not versioned... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #5 from Petr Šabata <psabata(a)redhat.com&gt; --- (In reply to Colin Macdonald from comment #3) Unicode::Collate is indeed bundled with perl but also lives on on CPAN as a separate distribution ("dual-lives"). What we can do is to subpackage the module from the perl package and then package the standalone Unicode::Collate module which will update and replace the perl subpackage. We do this for many modules already and plan to subpackage most or all of them at some point. It's an ongoing work. If you really need the new Unicode::Collate, I can do that for you. Github generates tarballs from tags, you can use these: https://github.com/plk/biber/releases Also, v1.9 has been available for a while. Any reason to stick with 1.8? I would use the abovementioned tarballs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #7 from Colin Macdonald <cbm(a)m.fsf.org&gt; --- I guess (but don't know) that it really needed the a newer Unicode::Collate. Here is a commit for biber 1.9 which increments it to 1.04: https://github.com/plk/biber/commit/4a49c1a679de30a8834bb79844b08e49ced50058 I could ask upstream? Or ask you to do the subpackage :) If latter, I'll file a bug for that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #9 from Petr Šabata <psabata(a)redhat.com&gt; --- (In reply to Colin Macdonald from comment #6) Aha, I see. I haven't looked at the package yet :) (In reply to Colin Macdonald from comment #7) It could be just that the author had that specific version of Unicode::Collate installed. Maybe it's not really required. Or maybe it is. Maybe biber breaks in some situations if Unicode::Collate is too old :) You can ask upstream, sure. I'll subpackage it (next week) anyway. (In reply to Colin Macdonald from comment #8) There's no inheritence. These can differ and they often do (e.g. when not everything is tested). You need to list that twice. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #11 from Colin Macdonald <cbm(a)m.fsf.org&gt; --- Upstream thinks we can relax the Unicode::Collate requirement so I'll do that and leave a comment in the spec file on my next revision. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Bug 1165620 depends on bug 1165627, which changed state. Bug 1165627 Summary: Review Request: perl-XML-LibXML-Simple - XML::LibXML clone of XML::Simple::XMLin() https://bugzilla.redhat.com/show_bug.cgi?id=1165627 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Bug 1165620 depends on bug 1165629, which changed state. Bug 1165629 Summary: Review Request: perl-Getopt-Tabular - Table-driven argument parsing for Perl 5 https://bugzilla.redhat.com/show_bug.cgi?id=1165629 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Bug 1165620 depends on bug 1165637, which changed state. Bug 1165637 Summary: Review Request: perl-Business-ISSN - Perl extension for International Standard Serial Numbers https://bugzilla.redhat.com/show_bug.cgi?id=1165637 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Bug 1165620 depends on bug 1165641, which changed state. Bug 1165641 Summary: Review Request: perl-Text-BibTeX - Interface to read and parse BibTeX files https://bugzilla.redhat.com/show_bug.cgi?id=1165641 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #13 from Petr Šabata <psabata(a)redhat.com&gt; --- So, after checking your long dep list: Missing build-time dependencies: - perl itself - it is called in the spec file - Log::Log4perl::Appender::File - Log::Log4perl::Appender::Screen - Log::Log4perl::Layout::PatternLayout - Log::Log4perl::Layout::SimpleLayout - these are via tests -> Biber -> Biber::Config - re - this is via tests -> Biber -> Biber::Utils - Text::BibTeX::Name - Text::BibTeX::NameFormat - these are via tests -> Biber::Input::file::bibtex I think you can safely drop the following build-time deps: - Business::ISBN - Business::ISSN - Business::ISMN - this code isn't tested - Config::AutoConf - Encode::EUCJPASCII - Encode::HanExtra - Encode::JIS2K - ExtUtils::LibBuilder - these aren't actually used anywhere - Getopt::Long - only used by the script and it's not tested - List::MoreUtils - again, not used anywhere - LWP::Simple - LWP::Protocol::https - Mozila::CA - this code isn't tested - Pod::Usage - only used by the script, not tested - Readonly - Readonly::XS - not tested; furthermore, the XS variant is only recommended for improved performance - Unicode::Collate - amusing, isn't it? It's not actually used anywhere; some of its submodules are but not this one -- and with the dependency constraint removed, you can just drop this completely - XML::LibXSLT - this code isn't tested - XML::Writer::String - this isn't used anywhere, not even mentioned in META; where did you find it?... Now, for the runtime dependencies. These can be dropped from the list because rpmbuild's generators will automagically find them for you: - autovivification - Data::Dump - Data::Compare - Data::Simple - File::Slurp - IPC::Cmd - IPC::Run3 - List::AllUtils - Log::Log4perl - Regexp::Common - Unicode::GCString - URI - XML::Writer And these just aren't needed at all: - Encode::EUCJPASCII - Encode::HanExtra - Encode::JIS2K - List::MoreUtils - Unicode::Collate - XML::Writer::String Note Text::BibTeX gets autodetected too, however, it's missing the version constraint. Therefore keep your explicit runtime dependency and filter out the autogenerated one, like this, on one line: %global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(Text::BibTeX\\)$ You also need to add this to your runtime dep list, the generators won't pick it up: - Unicode::Collate::Locale That should be all for the deps, next... The license tag is incorrect. The README file states the distribution is licensed under GPL+ or Artistic 2.0, however, all the code mentions Artistic 2.0 only. I would suggest using `(GPL+ or Artistic 2.0) and Artistic 2.0' here. And perhaps package TODO.org as %doc, too. Hopefully that's all there is to this review :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #15 from Colin Macdonald <cbm(a)m.fsf.org&gt; --- Oh and here is a the diff of my latest change in case that helps: https://github.com/cbm755/fedora-spec/commit/1197bb3b39655e315a57f9d12459... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #17 from Colin Macdonald <cbm(a)m.fsf.org&gt; --- New Package SCM Request ======================= Package Name: biber Short Description: Command-line bibliographic manager, BibTeX replacement Upstream URL: http://biblatex-biber.sourceforge.net/ Owners: cbm mef jnovy Branches: f22 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Jon Ciesla <limburgher(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA --- Comment #20 from Fedora Update System <updates(a)fedoraproject.org&gt; --- biber-1.8-8.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component