Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka(a)ioa.s.u-tokyo.ac.jp --- Comment #1 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2009-06-07 10:42:02 EDT --- Some basic comments (please also consider to apply the following comments to the rest of your rubygem related review requests). - Use %global instead of %define: https://fedoraproject.org/wiki/Packaging/Ruby#Pure_Ruby_packages https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define - Requires: ruby(abi) = 1.8 is missing https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines And for consistency I recommend to add BuildRequires: ruby(abi) = 1.8 - As you have already defined %geminstdir, please use it also at %files and so on - %geminstdir/[A-Z]* should be marked as %doc - Please check if Rakefile or install.rb are needed for binary rpm. --------------------------------------------------------------------- # Examples are documentation mv $RPM_BUILD_ROOT%{gemdir}/gems/%{gemname}-%{version}/examples \ $RPM_BUILD_ROOT%{gemdir}/doc/%{gemname}-%{version} --------------------------------------------------------------------- - Note that --------------------------------------------------------------------- $ gem contents term-ansicolor --------------------------------------------------------------------- expects that examples/ directory should be under %geminstdir. While we allow (don't forbid) to delete some files listed in "$ gem contents <gemname>") if packagers think they are not needed, I don't think moving examples/ directory under %gemdir/doc is needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 --- Comment #3 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2009-06-07 11:06:14 EDT --- (In reply to comment #2) <snip> I think you can just modify your rest srpm and don't have to copy my comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |mtasaka(a)ioa.s.u-tokyo.ac.jp Flag| |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 --- Comment #6 from Lubomir Rintel <lkundrak(a)v3.sk&gt; 2009-06-08 11:57:05 EDT --- (In reply to comment #5) I am aware of this and believe that it is ok. Makes no real harm and saves me from enumerating the contents of the directory just to avoid duplicate listings. Will fix (for other packages as well). I can do this (and for other packages as well) if you insist on eliminate of "listed twice" warning but I'll prefer not to. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(lkundrak(a)v3.sk) --- Comment #8 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2009-06-16 12:42:16 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 --- Comment #9 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2009-06-26 09:21:05 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2009-06-26 10:48:51 EDT --- ----------------------------------------------------------------- This package (rubygem-term-ansicolor) is APPROVED by mtasaka ----------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 Jason Tibbitts <tibbs(a)math.uh.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ --- Comment #13 from Jason Tibbitts <tibbs(a)math.uh.edu&gt; 2009-06-26 20:43:20 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504469 --- Comment #14 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; 2009-06-27 03:06:59 EDT --- Not applied to this package, however some notes: - If rubygem based rpm package contains %{geminstdir}/test , would you try to add %check section and execute some test program like below? http://cvs.fedoraproject.org/viewvc/rpms/rubygem-hpricot/devel/rubygem-hp... https://fedoraproject.org/wiki/PackagingDrafts/Gem_expand_stage_change (The latter one is a draft and currently I am waiting from the feedback from any person. If you have time I will appreciate it if you comment on: https://www.redhat.com/archives/fedora-packaging/2009-June/msg00069.html ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.