https://bugzilla.redhat.com/show_bug.cgi?id=1238755 Wim Taymans <wtaymans(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1129638 CC| |mail(a)stefanringel.de --- Comment #1 from Wim Taymans <wtaymans(a)redhat.com&gt; --- *** Bug 1129677 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1129638 [Bug 1129638] Update to gnome-dvb-daemon 0.2.90 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1238755 --- Comment #3 from Kalev Lember <kalevlember(a)gmail.com&gt; --- Here's rpmlint output: $ rpmlint gstreamer1-rtsp-server-1.4.0-3.fc23.src.rpm \ gstreamer1-rtsp-server \ gstreamer1-rtsp-server-devel \ gstreamer1-rtsp-server-devel-docs \ gstreamer1-rtsp-server-debuginfo gstreamer1-rtsp-server.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-rtsp-server.src:98: W: macro-in-%changelog %make_install gstreamer1-rtsp-server.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstbase-1.0.so.0 gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstrtp-1.0.so.0 gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libpthread.so.0 gstreamer1-rtsp-server-devel.x86_64: W: only-non-binary-in-usr-lib gstreamer1-rtsp-server-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 8 warnings. Most of it is noise, but the "W: macro-in-%changelog %make_install" issue would be important to fix. rpm expands macros anywhere, even in the %changelog section and that means it also expands the %make_install macro, messing up the changelog section. Easiest would be to either escape the macro with %% or just remove the % macro symbol in front of it. Some other things I noticed while going through the spec file; none of those are review blockers but might be nice to fix: I think this comment can go? Introspection seems to be enabled in the build now. passing --disable-static to %configure would probably be slightly nicer than building the static library and then deleting it afterwards COPYING.LIB should be marked %license as per latest guideline updates. Not sure TODO is useful to package at all? and %files devel %dir %{_datadir}/gir-%{majorminor}/ %{_datadir}/gir-%{majorminor}/GstRtspServer-%{majorminor}.gir The girepository-1.0 and gir-1.0 directory versions are the gobject introspection version and using the rtsp-server's majorminor here is probably wrong. I'd just write 1.0 instead of using the macro. Should include the %{_datadir}/gtk-doc/ and %{_datadir}/gtk-doc/html/ directories in the package as well to avoid leaving unowned directories behind on uninstall. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1238755 Kalev Lember <kalevlember(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Kalev Lember <kalevlember(a)gmail.com&gt; --- Fedora review gstreamer1-rtsp-server-1.4.0-4.fc22.src.rpm 2015-07-27 $ rpmlint gstreamer1-rtsp-server-1.4.0-4.fc22.src.rpm \ gstreamer1-rtsp-server \ gstreamer1-rtsp-server-debuginfo \ gstreamer1-rtsp-server-devel gstreamer1-rtsp-server-devel-docs gstreamer1-rtsp-server.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-rtsp-server.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstbase-1.0.so.0 gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstrtp-1.0.so.0 gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libpthread.so.0 gstreamer1-rtsp-server-devel.x86_64: W: only-non-binary-in-usr-lib gstreamer1-rtsp-server-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 7 warnings. + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The license text (COPYING.LIB) is included in %license + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 974af05dbf867cade89b8d3101e3f197 gst-rtsp-server-1.4.0.tar.xz 974af05dbf867cade89b8d3101e3f197 Download/gst-rtsp-server-1.4.0.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling + ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content + Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static + Development files should be in -devel + -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Looks good to me. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1238755 Jon Ciesla <limburgher(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1238755 Wim Taymans <wtaymans(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2015-09-07 07:22:32 --- Comment #8 from Wim Taymans <wtaymans(a)redhat.com&gt; --- Is now in f23 and rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component