[Bug 1238755] Review Request: gstreamer1-rtsp-server - A GStreamer 1.x based RTSP server

https://bugzilla.redhat.com/show_bug.cgi?id=1238755 --- Comment #3 from Kalev Lember <kalevlember(a)gmail.com&gt; --- Here's rpmlint output: $ rpmlint gstreamer1-rtsp-server-1.4.0-3.fc23.src.rpm \ gstreamer1-rtsp-server \ gstreamer1-rtsp-server-devel \ gstreamer1-rtsp-server-devel-docs \ gstreamer1-rtsp-server-debuginfo gstreamer1-rtsp-server.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-rtsp-server.src:98: W: macro-in-%changelog %make_install gstreamer1-rtsp-server.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstbase-1.0.so.0 gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstrtp-1.0.so.0 gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libpthread.so.0 gstreamer1-rtsp-server-devel.x86_64: W: only-non-binary-in-usr-lib gstreamer1-rtsp-server-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 8 warnings. Most of it is noise, but the "W: macro-in-%changelog %make_install" issue would be important to fix. rpm expands macros anywhere, even in the %changelog section and that means it also expands the %make_install macro, messing up the changelog section. Easiest would be to either escape the macro with %% or just remove the % macro symbol in front of it. Some other things I noticed while going through the spec file; none of those are review blockers but might be nice to fix: I think this comment can go? Introspection seems to be enabled in the build now. passing --disable-static to %configure would probably be slightly nicer than building the static library and then deleting it afterwards COPYING.LIB should be marked %license as per latest guideline updates. Not sure TODO is useful to package at all? and %files devel %dir %{_datadir}/gir-%{majorminor}/ %{_datadir}/gir-%{majorminor}/GstRtspServer-%{majorminor}.gir The girepository-1.0 and gir-1.0 directory versions are the gobject introspection version and using the rtsp-server's majorminor here is probably wrong. I'd just write 1.0 instead of using the macro. Should include the %{_datadir}/gtk-doc/ and %{_datadir}/gtk-doc/html/ directories in the package as well to avoid leaving unowned directories behind on uninstall. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component