Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-openid - The PHP OpenID Library https://bugzilla.redhat.com/show_bug.cgi?id=439285 orion(a)cora.nwra.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody(a)fedoraproject.org |orion(a)cora.nwra.com Status|NEW |ASSIGNED Flag| |fedora-review- ------- Additional Comments From orion(a)cora.nwra.com 2008-03-28 16:43 EST ------- Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream e8be2d48139b4faa45626661c329bdb2 php-openid-2.0.1.tar.bz2 e8be2d48139b4faa45626661c329bdb2 php-openid-2.0.1.tar.bz2.orig - package compiles on devel (x86) - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Questions: Why do you need to BR php-common? It appears to build fine without it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-openid - The PHP OpenID Library https://bugzilla.redhat.com/show_bug.cgi?id=439285 ianweller(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(orion(a)cora.nwra.co | |m) ------- Additional Comments From ianweller(a)gmail.com 2008-03-29 14:34 EST ------- there were more issues that i found myself... version 2.0.1-2. spec - http://ianweller.fedorapeople.org/SRPMS/php-openid/2.0.1-2/php-openid.spec srpm - http://ianweller.fedorapeople.org/SRPMS/php-openid/2.0.1-2/php-openid-2.0... * Sat Mar 29 2008 Ian Weller <ianweller(a)gmail.com&gt; 2.0.1-2 - Removed unnecessary BuildRequires - Added provides php-yadis, since it does - Put everything under an Auth directory in datadir/php, because otherwise the code wouldn't work Also, another issue that has come up: if this package were to pass review, it would supersede bug 227190 and bug 227191, two packages for OpenID and Yadis in PHP. I've contacted the packager about this, and I've looked at the review requests, and it seems like they shouldn't be provided under the php-pear name, since I can't find OpenID in pear, and Yadis is out of date compared to URL0 for this package. orion: are you still willing to review this? i noticed you set fedora-review to -. i don't usually see that, i usually see them leave it at ? when there's still fixable issues... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-openid - The PHP OpenID Library https://bugzilla.redhat.com/show_bug.cgi?id=439285 lemenkov(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |CLOSED Resolution| |DUPLICATE Flag|needinfo?(orion(a)cora.nwra.co| |m) | ------- Additional Comments From lemenkov(a)gmail.com 2008-07-05 03:26 EST ------- *** This bug has been marked as a duplicate of 227190 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.