[Bug 439285] Review Request: php-openid - The PHP OpenID Library

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-openid - The PHP OpenID Library https://bugzilla.redhat.com/show_bug.cgi?id=439285 orion(a)cora.nwra.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody(a)fedoraproject.org |orion(a)cora.nwra.com Status|NEW |ASSIGNED Flag| |fedora-review- ------- Additional Comments From orion(a)cora.nwra.com 2008-03-28 16:43 EST ------- Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream e8be2d48139b4faa45626661c329bdb2 php-openid-2.0.1.tar.bz2 e8be2d48139b4faa45626661c329bdb2 php-openid-2.0.1.tar.bz2.orig - package compiles on devel (x86) - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Questions: Why do you need to BR php-common? It appears to build fine without it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.