Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=816334
Thomas Spura <tomspur(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tomspur(a)fedoraproject.org
AssignedTo|nobody(a)fedoraproject.org |tomspur(a)fedoraproject.org
Flag| |fedora-review+
--- Comment #1 from Thomas Spura <tomspur(a)fedoraproject.org> 2012-04-28 08:16:08 EDT
---
Review:
- name ok
- obsoletes/provides fine
- BR ok
- R mostly ok
(I'd prefer to do a review of Django-south first, so you don't need to take
care of that rename in this spec file in the future)
- license ok (some files are BSD 3-clause which is compatible with GPLv3
- noarch ok
- egg removed
- %files ok
- builds in koji (see above)
- $ rpmlint
/home/tomspur/rpmbuild/SRPMS/python-django-authenticator-0.1.5-1.fc16.src.rpm
/home/tomspur/rpmbuild/RPMS/noarch/python-django-authenticator-0.1.5-1.fc16.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- source matches upstream:
a4d03d4c4c0d1dcd81a36b2b9039953b django-authenticator-0.1.5.tar.gz
SHOULD:
- It might be possible to run nosetests.
- Query upstream to add a LICENSE file
COMMENT:
- obs_ver is unlikely to change, so I'd hardcode it in the obsoletes
---------------------------------------------------------------------
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.