Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: eclipse-setools - SETools Eclipse Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=390571
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-11-30 09:55 EST
-------
(In reply to comment #15)
You are suggesting the 1997svn because the source is being pulled
from an SVN
tree directly? Would it be better to generate and post a source tarball from
the SVN tree and use that in Source0?
Umm? What do you mean by the second sentence? Is the tarball
currently used as Source0 is not from SVN tree?
I am suggesting 1997svn because your spec file reads that
you created Source0 from svn repository and when I tried the
current revision seems 1997.
And 3.3.2-X vs 3.3.2-0.X because of the versioning of the dependency
setools-java-libs?
No. As written by
http://fedoraproject.org/wiki/Packaging/NamingGuidelines ,
if the tarball used as Source0 is the "pre-release" of 3.3.2
you should use "3.3.2-0.X" for EVR of Fedora rpm. If not
(i.e. if the tarball used as Source0 is after the release of 3.3.2),
you should use "3.3.2-X"
The 3.3.2 release is 'formal'. If there are code changes in
the future the version will go to 3.3.3 (or higher). I don't think this rpm
should care about the -X of the setools-libs-java rpm.
X (this is a integer) is not related to setools. X means that
if you change the spec file of eclipse-setools, you should change
the EVR as 3.3.2-1, 3.3.2-2, ..... as before.
Personally I would like to leave the version as 3.3.2-X and post a
source
tarball.
Well, would you write again how you created the Source0?
- If there is a URL from which we can download the tarball used
as Source0, use the URL as Source0 and use 3.3.2-{1,2,3,...} as
EVR.
- If you used svn to create souce tarball, you should use
3.3.2-2.svn1997 -> 3.3.2-3.svn1997 -> 3.3.2-4.svn1998 ->
3.3.3-1.svn2000 (for example).
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.