Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |mtasaka(a)ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-30 12:54 EST ------- First review for libstroke: 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Licensing + This package says it is distributed under GPL, however, this does not include the copy of GPL license. I won't block this package by this issue, however, it is recommended that you ask for upstream to include GPL documents to this package. * Requires - %package -n libgstroke-devel Conflicts: libstroke-devel What does this mean? Is there any way to remove this conflict sentence? * BuildRequirs - texinfo Is this really required? It seems that makeinfo is not used in rebuilding. - libX11-devel <- required by gtk+-devel * File and Directory Ownership %{_datadir}/libstroke %{_datadir}/libstroke/java %{_datadir}/libstroke/test --- not owned by any packages. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines = Nothing. 3. Other things I have noticed = Nothing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-30 14:26 EST ------- Well: * I just want to know why libgstroke-devel conflicts with libstroke-devel . * %{_datadir}/stroke/ (in main package) Well, no. When writing as this, this (main) package includes the directory %{_datadir}/stroke/ and all files under this directory. If you want to include only the directory, explicit declaration of %dir is needed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 ------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-30 14:53 EST ------- Updated: Spec URL: http://chitlesh.funpic.de/rpm/libstroke.spec SRPM URL: http://chitlesh.funpic.de/rpm/libstroke-0.5.1-8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-30 15:01 EST ------- (In reply to comment #4) Umm.. I still cannot understand why these conflicts each other. ( as Mark says ) * File lists do not make duplicate. * When using libstroke-devel, it requires to write "include <stroke.h>" in source code and to use -lstroke. On the other hand when using libgstroke-devel they changes to "include <gstroke.h>" and -lgstroke . They never overwrite each other. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-30 15:32 EST ------- Well: As was in main package %files -n %{name}-devel %{_datadir}/stroke/tests/ %{_datadir}/stroke/tests/stroke_test %{_datadir}/stroke/tests/stroke_test.tcl %files -n javastroke %{_datadir}/stroke/java/ %{_datadir}/stroke/java/*.java These are duplicates. Please check file entries so that * all necessary files and directories are owned. * duplicate files are not listed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-30 16:03 EST ------- (In reply to comment #10) Well, not yet okay. rpm -qlp *0.5.1*rpm | sort says /usr/share/stroke/tests /usr/share/stroke/tests/gnome_stroke_test /usr/share/stroke/tests/gnome_stroke_test /usr/share/stroke/tests/stroke_test /usr/share/stroke/tests/stroke_test.tcl /usr/src/debug/libstroke-0.5.1 ... /usr/share/stroke/tests/gnome_stroke_test is owned by libstroke-devel and libgstroke-devel and... from this package: there is a case that only libgstroke and libgstroke-devel and libstroke are installed: in that case the directory %{_datadir}/stroke/tests/ is not owned by any packages. This is not correct. So: %files -n %{name} %defattr(-,root,root) %doc README COPYRIGHT ChangeLog NEWS AUTHORS TODO CREDITS %dir %{_datadir}/stroke/ %dir %{_datadir}/stroke/tests/ %{_libdir}/libstroke.so.* %files -n %{name}-devel %defattr(-,root,root) %doc doc/standard_strokes* %{_datadir}/stroke/tests/stroke_test* %{_datadir}/aclocal/libstroke.m4 %{_libdir}/libstroke.so %{_includedir}/stroke.h %files -n libgstroke %defattr(-,root,root) %doc README COPYRIGHT ChangeLog NEWS AUTHORS TODO CREDITS %{_libdir}/libgstroke.so.* %files -n libgstroke-devel %defattr(-,root,root) %doc README.libgstroke %{_datadir}/stroke/tests/gnome_stroke_test %{_datadir}/aclocal/libgstroke.m4 %{_libdir}/libgstroke.so %{_includedir}/gstroke.h %files -n javastroke %defattr(-,root,root) %doc javastroke/README %{_datadir}/stroke/java/ is correct (I think. check it). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libstroke - A stroke interface library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204423 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-31 22:50 EST ------- Well, now the files/directories ownership consistency is okay. I checked my mock build and it turned out that automake is unnecessary for BuildRequires as automake and so on is not called in rebuilding and I suceeded in rebuilding this with automake removed from BR. Please remove automake from BuildRequires, which is the only things to be fixed. This package is APPROVED by me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=204423 Chitlesh GOORAH <cgoorah(a)yahoo.com.au&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #14 from Chitlesh GOORAH <cgoorah(a)yahoo.com.au&gt; 2008-12-21 14:33:03 EDT --- New Package CVS Request ======================= Package Name: libstroke Short Description: A stroke interface library Owners: chitlesh Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.