Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: geda-symbols - Electronic symbols for gEDA
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204263
------- Additional Comments From cgoorah(a)yahoo.com.au 2006-08-29 10:51 EST -------
(In reply to comment #2)
Try to change "make install" option so that (perhaps)
most files can keep timestamps. In xscreensaver case (I maintain
xscreensaver), I use
make INSTALL="install -p" install
Check if this package accepts such options, or, if not,
It accepts "-p" ::)
make INSTALL="install -p" install DESTDIR=%{buildroot}
* File and Directory Ownership
- %{_datadir}/gEDA/scheme
%{gedadocdir}/man
I don't know why these empty directories needs to be
included in this package.
3. Other things I have noticed :
- Consider if /usr/share/gEDA/docs can be moved
to usual document files' location, i.e.
/usr/share/doc/geda-symbols-%{version}
Actually geda-gsymbols are required by geda-gschem geda-gsymcheck geda-doc
geda-gattrib geda-gnetlist geda-utils.
And all these are required by geda which is a suite. (though i haven't YET
included them as Requires in the geda package)
Hence these act as a centralised repository for geda.
- I will attach the file entry of geda-symbols rebuilt in
mock. Please check if all files you want to install in
this package are correctly packaged.
Yes, everything is included :) luckily
Updated:
SPEC:
http://chitlesh.googlepages.com/geda-symbols.spec
SRPM:
http://chitlesh.googlepages.com/geda-symbols-20060123-4.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.