Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libgeda - the library needed by gEDA applications.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204168
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-29 00:58 EST
-------
Review for libgeda:
1. From
http://fedoraproject.org/wiki/Packaging/Guidelines :
* BuildRequires
- pkgconfig is not needed because:
glib2-devel requires pkgconfig and
gtk2-devel (written) requires glib2-devel
- added texi2html as BR to set HTML file creation enabled
However, no HTML documents are installed and I cannot see
the place where /usr/bin/texi2html is used in build log.
Is texi2html needed?
* Requires
- -devel package.
Check precisely the Requires of -devel package as the
requirement of -devel package cannot be pulled automatically.
/usr/lib/pkgconfig/libgeda.pc says:
Libs: -L${libdir} -lgeda -pthread -lguile -L/lib -lglib-2.0 \
-L/lib -lgdk_pixbuf-2.0 ......
This means that this package (libgeda-devel) requires guile-devel,
glib2-devel, gtk2-devel, .......
Add all these requirement, then remove redundant packages.
For example, glib2-devel is requires by gtk2-devel, so explicit
requirement of "glib2-devel" is not necessary.
* Scriptlets requirements
Add /sbin/ldconfig to main Requires(postun) .
2. Fro
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
3. Other things I have noticed:
* %exclude %{_libdir}/libgeda.la
Well, finally %{_libdir}/libgeda.la is not installed, so remove
this file on %install stage (rm -f $BUILD_ROOT%{_libdir}/*.la)
and get rid of this entry.
* %doc
Why do main and -devel packages have the same documents?
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.