https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #3 from Patrik Kopkan <pkopkan(a)redhat.com&gt; --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... I was little bit confused they are just optional. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #5 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- A suggestion about python_to_python3.patch: Don't change "python" to "python3", change it to sys.executable and propose that change upstream. You can link to https://www.python.org/dev/peps/pep-0394/#recommendation ------ # this is optional but tests for spinners are failing because of that so I decided to make that hard requires It is not uncommon that tests need also optional dependencies. Reading the code in https://github.com/sarugaku/vistir/blob/master/src/vistir/spin.py I suggest you use Recommends instead of Requires. ------ Any particular reason to mix python3dist(xxx) and python3-xxx in BuildRequires? I stick to one. Also, the #for tests comment is kinda weird, aren't others also needed for tests? ------ # one test require internet to pass %bcond_without internet ... %if %{with internet} -k 'not test_open_file' %endif This feels like a reverted logic. When I use "--without internet" the test that requires internet will run, while when I use "--with internet" the test that requires internet won't run. (Bconds are confusing.) What about this instead: # one test requires internet connection, we deselect it by default unless --with internet is used %bcond_with internet ... %if %{without internet} -k 'not test_open_file' %endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #7 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- The linked specfile is not consistent with this statement (there is no subpackage, the recommends are commented out). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #9 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- What happens if the user only installs python3-vistir-spinners? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #11 from Patrik Kopkan <pkopkan(a)redhat.com&gt; --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... Now it could be fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #13 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- (In this case, think of the python3-vistir package as the "base package" when you read the guideline.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #15 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - description-line-too-long C Miscellaneous utilities for dealing with filesystems, paths, projects, sub-processes, and more. - dependencies are still not packaged (known) - have you proposed your patch upstream? ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-vistir-0.3.0-1.fc30.noarch.rpm python3-vistir-spinners-0.3.0-1.fc30.noarch.rpm python-vistir-0.3.0-1.fc30.src.rpm python3-vistir.noarch: E: description-line-too-long C Miscellaneous utilities for dealing with filesystems, paths, projects, sub-processes, and more. python3-vistir-spinners.noarch: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 1 warnings. Requires -------- python3-vistir-spinners (rpmlib, GLIBC filtered): python3-cursor python3-vistir python3-yaspin python3-vistir (rpmlib, GLIBC filtered): python(abi) python3.7dist(colorama) python3.7dist(requests) python3.7dist(six) Provides -------- python3-vistir-spinners: python3-vistir-spinners python3-vistir: python3-vistir python3.7dist(vistir) python3dist(vistir) Source checksums ---------------- https://github.com/sarugaku/vistir/archive/0.3.0.tar.gz : CHECKSUM(SHA256) this package : e41ce20300edc7656e7d7cba16dacfe0ee833df6f1c14e98feae2938afeb472c CHECKSUM(SHA256) upstream package : e41ce20300edc7656e7d7cba16dacfe0ee833df6f1c14e98feae2938afeb472c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 Bug 1671790 depends on bug 1671788, which changed state. Bug 1671788 Summary: Review Request: python-hypothesis-fspaths - python library for generating file system paths https://bugzilla.redhat.com/show_bug.cgi?id=1671788 What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #17 from Patrik Kopkan <pkopkan(a)redhat.com&gt; --- Spec URl: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... upstream agreed on patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #19 from Patrik Kopkan <pkopkan(a)redhat.com&gt; --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... Test passed. I deleted patch0 and build require for python-cursor. Interesting difference could be bumped version of setuptools because of that it won't be build successfully in fedora 29. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 Bug 1671790 depends on bug 1671787, which changed state. Bug 1671787 Summary: Review Request: python-cursor - python package for hiding terminal cursor https://bugzilla.redhat.com/show_bug.cgi?id=1671787 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek(a)in.waw.pl --- Comment #22 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- Looking at https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed...: things look OK, but the -spinners subpackage is uninstallable: Error: Problem: conflicting requests - nothing provides python3-cursor needed by python3-vistir-spinners-0.3.1-1.fc31.noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #24 from Patrik Kopkan <pkopkan(a)redhat.com&gt; --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... Thank you, I forgot to delete that. Also i bumped the version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #26 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- spinners is a metapackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #28 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; --- What is the goal of this metapackage? Why not just use Recommends: ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #30 from Patrik Kopkan <pkopkan(a)redhat.com&gt; --- It give to user info that there is some not strictly required dependency for spinners in vistir. I find that more saying than yaspin. I copied idea from setup.cfg https://github.com/sarugaku/vistir/blob/798a4ecbb528cd160e0d8f8322098c455... It is just little detail on which I don't care much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #32 from Patrik Kopkan <pkopkan(a)redhat.com&gt; --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pkopkan/python-vistir/fed... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1671790 --- Comment #34 from Mohan Boddu <mboddu(a)bhujji.com&gt; --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-vistir -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component