https://bugzilla.redhat.com/show_bug.cgi?id=1671790
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mhroncok(a)redhat.com
--- Comment #2 from Miro Hrončok <mhroncok(a)redhat.com> ---
I will not yet try to build this or assign this to me, but several notes:
Patch0: vistir-patch.patch
What is this? Why is it named "patch"? Please make the name as much descriptive
as possible, add comment if needed.
# setuptools>=38.2.5
BuildRequires: python3-setuptools
Use the version limit or don't, there is no try. The comment is useless.
Requires: python3dist(colorama)
Requires: python3dist(requests)
Requires: python3dist(six)
Are those not added automatically?
# should be optional because they are bundled but doesn't work
Requires: python3-yaspin
Requires: python3-cursor
What does it actually mean that they should be optional because bundled? What
does it mean it doesn't work?
%autosetup -n %{srcname}-%{version} -p2
Try to use git-like patches (-p1) if you can. It makes work for others as easy
as possible.
PYTHONPATH=./build/lib %{__python3} -m pytest tests
Try to use the installed package for testing instead.
PYTHONPATH=%{buildroot}%{python3_sitelib}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component