11:45 a.m.
#42: Compilation fails when no lex library is present
-------------------------+-------------------------------------------------
Reporter: vogtmark | Owner: pam-developers@…
Type: defect | Status: new
Priority: major | Component: library
Version: 1.2.x | Keywords: lex library yywrap undefined
Blocked By: | reference
| Blocking:
-------------------------+-------------------------------------------------
In case none of the supported lex libraries (-lfl -ll) is present on the
system, compilation fails. The error is:
{{{
pam_conv_l.c:(.text+0x9f7): undefined reference to `yywrap'.
}}}
During configure phase, there is no error. Configure just says:
{{{
checking lex library... none needed
}}}
After looking at the configure script it seems that configure tries
various libs to link against while trying to compile a program requiring a
lex library. If none succeeds, the default "none needed" is returned. This
does not make sense to me. An error should be returned instead if no lex
library is found, since it obviously is required.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/42>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
11:51 a.m.
#42: Compilation fails when no lex library is present
-------------------------------------------------+-------------------------
Reporter: vogtmark | Owner: pam-
Type: defect | developers@…
Priority: major | Status: new
Version: 1.2.x | Component: library
Keywords: lex library yywrap undefined | Resolution:
reference | Blocked By:
Blocking: |
-------------------------------------------------+-------------------------
Comment (by vogtmark):
Sorry, the attached log files are not the correct ones. A added the
corrected versions.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/42#comment:1>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
7:42 p.m.
New subject: [PATCH] Do not use yywrap (ticket #42)
Our scanners do not really use yywrap. Explicitly disable yywrap
so that no references to yywrap will be generated and no LEXLIB
would be needed.
* conf/pam_conv1/Makefile.am (pam_conv1_LDADD): Remove.
* conf/pam_conv1/pam_conv_l.l: Enable noyywrap option.
* doc/specs/Makefile.am (padout_LDADD): Remove.
* doc/specs/parse_l.l: Enable noyywrap option.
---
conf/pam_conv1/Makefile.am | 2 --
conf/pam_conv1/pam_conv_l.l | 1 +
doc/specs/Makefile.am | 2 --
doc/specs/parse_l.l | 1 +
4 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/conf/pam_conv1/Makefile.am b/conf/pam_conv1/Makefile.am
index b9e6153..ce50b68 100644
--- a/conf/pam_conv1/Makefile.am
+++ b/conf/pam_conv1/Makefile.am
@@ -13,5 +13,3 @@ BUILT_SOURCES = pam_conv_y.h
noinst_PROGRAMS = pam_conv1
pam_conv1_SOURCES = pam_conv_l.l pam_conv_y.y
-
-pam_conv1_LDADD = @LEXLIB@
diff --git a/conf/pam_conv1/pam_conv_l.l b/conf/pam_conv1/pam_conv_l.l
index 25b6710..f563eee 100644
--- a/conf/pam_conv1/pam_conv_l.l
+++ b/conf/pam_conv1/pam_conv_l.l
@@ -24,6 +24,7 @@
extern int current_line;
%}
+%option noyywrap
%%
"#"[^\n]* ; /* skip comments (sorry) */
diff --git a/doc/specs/Makefile.am b/doc/specs/Makefile.am
index 2688220..36d53ba 100644
--- a/doc/specs/Makefile.am
+++ b/doc/specs/Makefile.am
@@ -21,6 +21,4 @@ noinst_PROGRAMS = padout
padout_SOURCES = parse_l.l parse_y.y
-padout_LDADD = @LEXLIB@
-
doc_DATA = draft-morgan-pam-current.txt rfc86.0.txt
diff --git a/doc/specs/parse_l.l b/doc/specs/parse_l.l
index 7cab424..d8400a0 100644
--- a/doc/specs/parse_l.l
+++ b/doc/specs/parse_l.l
@@ -8,6 +8,7 @@
#include "parse_y.h"
%}
+%option noyywrap
%%
\#[\$]+[a-zA-Z]*(\=[0-9]+)? return NEW_COUNTER;
--
ldv
3:08 a.m.
New subject: [PATCH] Do not use yywrap (ticket #42)
On Út, 2014-12-09 at 04:42 +0300, Dmitry V. Levin wrote:
Our scanners do not really use yywrap. Explicitly disable yywrap
so that no references to yywrap will be generated and no LEXLIB
would be needed.
Good! Please commit.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
(You'll never know whether the road is wrong though.)
4:21 a.m.
#42: Compilation fails when no lex library is present
-------------------------------------------------+-------------------------
Reporter: vogtmark | Owner: pam-
Type: defect | developers@…
Priority: major | Status: closed
Version: 1.2.x | Component: library
Keywords: lex library yywrap undefined | Resolution: fixed
reference | Blocked By:
Blocking: |
-------------------------------------------------+-------------------------
Changes (by ldv):
* status: new => closed
* resolution: => fixed
Comment:
Thanks, fixed by commit https://git.fedorahosted.org/cgit/linux-
pam.git/commit/?id=Linux-PAM-1_1_8-57-g8da3f3c
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/42#comment:2>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
3427
days inactive
3466
days old
pam-developers@lists.fedorahosted.org
4 comments
3 participants
participants (3)
-
Dmitry V. Levin -
fedora-badges -
Tomas Mraz