Re: [Pam-developers] [linux-pam] Allow links to be used instead of w3m for documentation regeneration.
4:36 a.m.
On Fri, Sep 04, 2015 at 08:36:46AM +0000, Tomáš Mráz wrote:
[...]
- enable_docu=no
+ AC_PATH_PROG([BROWSER], [links])
+ if test ! -z "$BROWSER"; then
test -n "$BROWSER"
--
ldv
4:45 a.m.
New subject: [linux-pam] Allow links to be used instead of w3m for documentation regeneration.
On Pá, 2015-09-04 at 12:36 +0300, Dmitry V. Levin wrote:
On Fri, Sep 04, 2015 at 08:36:46AM +0000, Tomáš Mráz wrote:
[...]
> - enable_docu=no
> + AC_PATH_PROG([BROWSER], [links])
> + if test ! -z "$BROWSER"; then
test -n "$BROWSER"
True :), I just copied the same test from the w3m test.
Apparently in all the configure.ac source there is ! -z instead of -n.
Do we want to replace all these occurrences? Do you have an idea why !
-z was used instead of -n? Is there any shell where test -n does not
work?
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
(You'll never know whether the road is wrong though.)
4:55 a.m.
New subject: [linux-pam] Allow links to be used instead of w3m for documentation regeneration.
On Fri, Sep 04, Tomas Mraz wrote:
On Pá, 2015-09-04 at 12:36 +0300, Dmitry V. Levin wrote:
> On Fri, Sep 04, 2015 at 08:36:46AM +0000, Tomáš Mráz wrote:
> [...]
> > - enable_docu=no
> > + AC_PATH_PROG([BROWSER], [links])
> > + if test ! -z "$BROWSER"; then
>
> test -n "$BROWSER"
True :), I just copied the same test from the w3m test.
Apparently in all the configure.ac source there is ! -z instead of -n.
Do we want to replace all these occurrences? Do you have an idea why !
-z was used instead of -n? Is there any shell where test -n does not
work?
I'm not sure, but if I remember correct, there was a difference in
behavior if a variable does not exist or if it is empty.
But I couldn't find anything about this.
Thorsten
--
Thorsten Kukuk, Senior Architect SLES & Common Code Base
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
4:57 a.m.
New subject: [linux-pam] Allow links to be used instead of w3m for documentation regeneration.
On 04 Sep 2015, at 11:55, Thorsten Kukuk <kukuk(a)suse.de>
wrote:
On Fri, Sep 04, Tomas Mraz wrote:
> On Pá, 2015-09-04 at 12:36 +0300, Dmitry V. Levin wrote:
>> On Fri, Sep 04, 2015 at 08:36:46AM +0000, Tomáš Mráz wrote:
>> [...]
>>> - enable_docu=no
>>> + AC_PATH_PROG([BROWSER], [links])
>>> + if test ! -z "$BROWSER"; then
>>
>> test -n "$BROWSER"
>
> True :), I just copied the same test from the w3m test.
>
> Apparently in all the configure.ac source there is ! -z instead of -n.
> Do we want to replace all these occurrences? Do you have an idea why !
> -z was used instead of -n? Is there any shell where test -n does not
> work?
I'm not sure, but if I remember correct, there was a difference in
behavior if a variable does not exist or if it is empty.
But I couldn't find anything about this.
There is, but that’s already handled by using quotes. Without the quotes an empty
variables expands to nothing, while “$BROWSER” always expand to a (possible empty) string.
That guarantees test -n always has an argument to test.
Wichert.
3157
days inactive
3157
days old
pam-developers@lists.fedorahosted.org
3 comments
4 participants
participants (4)
-
Dmitry V. Levin -
Thorsten Kukuk -
Tomas Mraz -
Wichert Akkerman