Seems like a solid plan. Smaller details can be refined as well, but overall seems like a
good direction.
Unfortunately at this time there aren't free cycles for the python-maint team members,
so I doubt we would be able to push this for F26 as a system wide change on behalf of our
team at least.
So if noone is up for chasing this for the current development cycle, I would suggest
pushing it for F27.
Regards,
Charalampos Stratakis
Associate Software Engineer
Python Maintenance Team, Red Hat
----- Original Message -----
From: "Igor Gnatenko" <ignatenko(a)redhat.com>
To: "Fedora Python SIG" <python-devel(a)lists.fedoraproject.org>
Sent: Thursday, December 1, 2016 2:36:48 PM
Subject: Re: [RFC] RPM's Python dependency generator
On Wed, Nov 30, 2016 at 2:53 PM, Tomas Orsava <torsava(a)redhat.com> wrote:
On 11/30/2016 02:44 PM, Neal Gompa wrote:
>
> On Wed, Nov 30, 2016 at 8:41 AM, Tomas Orsava <torsava(a)redhat.com> wrote:
>>
>> I don't think the depgen should be enabled by default, at least not in
>> the
>> foreseeable future. IIRC it's not that well implemented—e.g. I believe it
>> doesn't read requirements.txt for example (but I might be wrong).
>> There will be a lot of cases where the generated requirements are
>> incomplete, or contain unnecessary entries, etc. I think it should remain
>> an
>> opt-in.
>>
> According to various Python people, we're not actually supposed to
> read requirements.txt. That file is explicitly designed for people to
> individualized deployments. The proper place to get this information
> is from the egg-info/dist-info data, which is what we read. The fact
> that some people abuse requirements.txt and have it read in by their
> setup.py is beside the point. Whatever the setup.py (thus
> pip/easy_install/etc.) says it needs, the generator will dutifully
> report.
The fact remains in too many cases it will need to be manually adjusted, it
won't be foolproof.
Therefore I argue it would be better for it to be an opt-in so that new
packagers don't immediately have to jump in into debugging a depgen they
have no clue how really works.
We'll see how it will go. we have depgen for
pkgconfig, libraries,
etc. for many years and people don't go and debug it immediately, but
for many of packages it will help a lot. Anyhow, we'll see after
couple of releases.
Neal suggested to have:
%__python_requires
%{_rpmconfigdir}/%{?pythondistdeps_enable:pythondistdeps.py}%{!?pythondistdeps_enable:pythondeps.sh}
--requires
in python.attr inside RPM.
I tested it and it just works once I specify `%global
pythondistdeps_enable 1` in spec. Can you help me to get this
included? With RPM part it's clear how to get this, but updating
guidelines and other stuff...
_______________________________________________
python-devel mailing list -- python-devel(a)lists.fedoraproject.org
To unsubscribe send an email to python-devel-leave(a)lists.fedoraproject.org
--
-Igor Gnatenko
_______________________________________________
python-devel mailing list -- python-devel(a)lists.fedoraproject.org
To unsubscribe send an email to python-devel-leave(a)lists.fedoraproject.org