-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/36/#review69
-----------------------------------------------------------
Ship it!
Looks good to me - it's now working in my dev env with that last change.
For future code, can you not make arbitrary stylistic changes to logic unless you're
in that code? I'm not going to say "back the changes out" this time but it
adds churn when it's not really needed.
- Tim Flink
On Aug. 16, 2013, 1:58 p.m., Ilgiz Islamgulov wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/36/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 1:58 p.m.)
Review request for blockerbugs.
Repository: blockerbugs
Description
-------
Add partial updates sync.
Display proposed/accepted fe/blocker bugs list associated with update on update list web
page.
Diffs
-----
testing/testfunc_update_sync.py 69f6bf8a459c71a9325cd633e7e33ce29354d7cd
testing/test_updatesync_extract_information.py 1fc701ef79a74e27cf8223b56a04d63025b6509f
testing/test_controllers.py f351832ad4350fcff3d67c0137ff62892639e908
blockerbugs/util/update_sync.py d664839ec1c5979dce980e7baad58154f4622e11
blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3
blockerbugs/templates/update_list.html a83dd9a422e51ea58e04ae58acd8fefe6eb1f79f
blockerbugs/models/update.py 2ee3ca7ee62bd55bbd71555c13fecfab504c4f07
blockerbugs/controllers/main.py e00593a6835d8d679ee155d7da02c452ce4827d1
blockerbugs/cli.py 694736d098b6285c53db91f91350360d478c4229
.gitignore c5f8d92163a31685a35109eb4847315d9ebcd220
Diff:
http://reviewboard-tflink.rhcloud.com/r/36/diff/
Testing
-------
Wrote test suites.
I've tested on my develop instance.
Thanks,
Ilgiz Islamgulov