Hello, ----- 元のメッセージ ----- Well, %gemspec_remove_dep is for gem "dependency" (i.e. to change "Requires: rubygem(foo)" on rpm side), right? What this do here is to change (remove) file entry in gem. sed loop is to remove one file by one file, so that afterwards we just have to modify "$f" list afterwards (perhaps). Regards, Mamoru

Though it's up to you, for example we do not need to check Fedora version in the macro by below way. sed -i -E 's|"'$f'"(.freeze)?, ||g' %{gem_name}.gemspec Jun Aruga ----- Original Message ----- > From: "Vít Ondruch" <vondruch(a)redhat.com&gt; > To: ruby-sig(a)lists.fedoraproject.org > Sent: Thursday, January 12, 2017 10:24:55 AM > Subject: Re: Ruby 2.4 - Mass rebuild > > Hi all, > > Seeing commit as this: > > > ``` > > @@ -44,9 +44,13 @@ gem unpack %{SOURCE0} > gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec > > # Remove developer-only files. > +FREEZE="" > +%if 0%{?fedora} >= 26 > +FREEZE=".freeze" > +%endif > for f in .gitignore Gemfile Rakefile; do > rm $f > - sed -i "s|\"$f\",||g" %{gem_name}.gemspec > done > > # Skip tests that fail. > > ``` > > (BTW is that sed in the loop?!?) > > I just want to remind you, that we have the %gemspec_remove_dep and > %gemspec_add_dep macros available in all Fedoras. You can see their > usage here: > > > http://pkgs.fedoraproject.org/cgit/rpms/rubygem-scruffy.git/commit/?id=be... > > > Still thinking where to document such stuff. I am very much in favor of > splitting such documentation in a similar manned as Java guys did, but I > am still indecisive ... > > > Vít > > > > Dne 10.1.2017 v 09:31 Vít Ondruch napsal(a): > > Hi all, > > > > So finally time for some fun. Since the Ruby 2.4 change proposal [1] was > > accepted, I asked release engineering for sidetag [3] to start with > > rebuild. This sidetag was granted and I was able to build there Ruby > > itself as well as several of my packages. Now is time for your help as > > well. > > > > What does it means? This is the list of packages which very likely needs > > to be rebuild: > > > > > > ``` > > $ dnf repoquery --disablerepo=* --enablerepo=rawhide > > --enablerepo=rawhide-source --arch=src --whatrequires 'ruby-devel' | > > sort | uniq > > > > ``` > > > > > > You can take the package and just fire rebuild, but please, you should > > be using f26-ruby24 build target [3], i.e. the build command should look > > like: > > > > > > ``` > > $ fedpkg build --target f26-ruby24 > > > > ``` > > > > > > If you forget to specify the target, you'll do build against Ruby 2.3, > > which is not what you want. > > > > If you don't make it soon enough, I'll very likely rebuild your package > > sooner or later. I'll be using fermig [4] to do that as I did during > > previous rebuilds. If you don't like me to touch you package for > > whatever reason, please let me know (Mamoru, I suppose you are going to > > rebuild your packages yourself, right?). > > > > You can follow the progress at: > > > > https://koji.fedoraproject.org/koji/builds?inherited=0&tagID=401&... > > > > or using: > > > > > > ``` > > $ koji list-tagged f26-ruby24 > > ``` > > > > As always, any help/testing/feedback is welcome. > > > > Vít > > > > > > [1] https://fedoraproject.org/wiki/Changes/Ruby_2.4 > > [2] https://pagure.io/fesco/issue/1659 > > [3] https://pagure.io/releng/issue/6579 > > [4] https://github.com/fedora-ruby/fermig > > _______________________________________________ > > ruby-sig mailing list -- ruby-sig(a)lists.fedoraproject.org > > To unsubscribe send an email to ruby-sig-leave(a)lists.fedoraproject.org > _______________________________________________ > ruby-sig mailing list -- ruby-sig(a)lists.fedoraproject.org > To unsubscribe send an email to ruby-sig-leave(a)lists.fedoraproject.org >