my PRs are rebased on top nirs/py3 branch.
On Wed, May 15, 2019 at 3:14 PM Nir Soffer <nsoffer(a)redhat.com> wrote:
On Wed, May 15, 2019 at 2:38 PM Amit Bawer <abawer(a)redhat.com>
wrote:
> Appreciated. Thanks
>
I refined the commit message here:
https://github.com/nirs/sanlock/commit/b227c77ceedfa6e1a838c5afb993426cd3...
And also added a new patch updating new assertions added in the 4k branch:
https://github.com/nirs/sanlock/commit/842627b493fa2bc1c9b4eeebf2022a22f8...
Please rebase your PR on top of the new py3 head.
>
> On Wed, May 15, 2019 at 2:37 PM Nir Soffer <nsoffer(a)redhat.com> wrote:
>
>> On Wed, May 15, 2019 at 2:32 PM Amit Bawer <abawer(a)redhat.com> wrote:
>>
>>> Thanks Vojtech.
>>> Nir - should we re-submit or we can bear with this typo?
>>>
>>
>> I can fix it in my tree before I push this if you like.
>>
>> On Wed, May 15, 2019 at 2:26 PM Vojtech Juranek <vjuranek(a)redhat.com>
>>> wrote:
>>>
>>>> > This patch is preparation for python3 convension.
>>>>
>>>> typo: convension -> conversion
>>>
>>>