On Tue, Mar 19, 2013 at 09:30:55AM +0100, Lukas Slebodnik wrote:
On (18/03/13 11:22), Jakub Hrozek wrote:
>On Wed, Mar 13, 2013 at 11:23:07AM +0100, Lukas Slebodnik wrote:
>> Hi,
>>
>> attached patch should fix ticket
>>
https://fedorahosted.org/sssd/ticket/1813
>>
>> Comments welcomed.
>>
>> LS
>
I have two more comments, sorry I haven't realized them the first time
around:
1) can you rename the LDB_VERSION_CHECK to not begin with LDB_ ? We
should not define new constants in libldb's namespace. Maybe something
like SSS_LDB_VERSION_CHECK would do..
2) Instead of two nested #ifdefs right after one another I think the
following is more readable:
#if defined LDB_VERSION_CHECK && defined LDB_MODULE_CHECK_VERSION
/* Do the check */
#endif
I have tested the approach and was able to run sssd with a different ldb
than it was built for.