URL:
https://github.com/SSSD/sssd/pull/838
Title: #838: FIPS140 compliant usage of PRNG
mzidek-rh commented:
"""
> Nitpick: You used tabs instead of spaces in the Makefile.am. It
is better to be consistent and use spaces.
Could you please elaborate on this?
```
git show c86a8033c6628c51d478e44d8dc4a0726988c826 Makefile.am | cat -T
...
-^I^I^Isrc/util/crypto/sss_crypto.c \
-^I^I^Isrc/util/atomic_io.c \
-^I^I^I$(NULL)
+ src/util/crypto/nss/nss_prng.c \
+ src/util/atomic_io.c \
+ $(NULL)
...
-^I^I^Isrc/util/crypto/sss_crypto.c \
-^I^I^Isrc/util/atomic_io.c \
-^I^I^I$(NULL)
+ src/util/crypto/libcrypto/crypto_prng.c \
+ src/util/atomic_io.c \
+ $(NULL)
```
It is other way around: I replaced tabs with spaces.
But I didn't touch it everywhere to keep diff small.
Ahm yes, sorry, disregard my comment, I was reading the diff wrong. The code LGTM, but I
would prefer if someone else reviewed the FIPS related patches.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/838#issuecomment-506340376