On (22/05/13 09:16), Sumit Bose wrote:
On Wed, May 22, 2013 at 08:24:08AM +0200, Lukas Slebodnik wrote:
> ehlo,
>
> Recommended way to create SRPM is to run make (prerelease-)srpm.
> But in previous case make file have to be generated, therefore
> configure script should not fail. (all sssd required dependencies have to be
> installed)
> Script make_srpm.sh can be runned without running configure, script can be
> runned only from git repository.
>
>
https://fedorahosted.org/sssd/ticket/1927
>
> Patch is attached.
Hi Lukas,
I haven't tested the script yet, nevertheless I have two comments. Please
add a copyright notice and a licence. Additionally I think '--define
I added
copyright.
_source_filedigest_algorithm=1' should be switch on by an option.
Iirc
we added it because RHEL5 could not handle newer hash algorithms here.
But on newer platforms we should use the platform defaults.
I removed line with
_source_filedigest_algorithm, because sssd master no longer
compiles on rhel5, nightly builds for rhel5 are done from sssd-1-9 branch.
But if you think, that it isn't proper solution I can add new switch for this.
Thank you very much for comments.
New patch attached.
LS