Re: [SSSD] [PATCH] AD: Use ad_site also when site search fails

On Mon, Jul 27, 2015 at 12:32:59PM +0200, Pavel Březina wrote: > On 07/21/2015 09:45 PM, Jakub Hrozek wrote: >> Hi, >> >> the attached patch helps AD clients that have trouble detecting the >> right site. Please see the patch and the commit message for more >> details. > > Hmm... nack. I think this change makes better job: > > if (state->ctx->ad_site_override != NULL) { > DEBUG(SSSDBG_TRACE_INTERNAL, > "Ignoring AD site found by DNS discovery: '%s', " > "using configured value: '%s' instead.\n", > state->site, state->ctx->ad_site_override); > state->site = state->ctx->ad_site_override; > + ret = EOK; > } That was my first version, too, but it appears that the EOK branch tries to access state->forest that is not known -- keep in mind that this is for cases where ad_get_client_site_recv() returned ENOENT so its output parameters might not be available. Can we infer the forest somehow?