Stephen Gallagher <sgallagh(a)redhat.com> wrote:
On 09/01/2010 05:56 AM, Jan Zelený wrote:
> Both your points are valid. I'm attaching a patch where the check is
> performed. I still think it is redundant, but it might be more safe in
> the future in case the code around it changes.
Nack.
This line:
dp_error = DP_ERR_FATAL;
is completely unnecessary. dp_error is never read again after this
assignment.
I realize that it was there before this patch, but it's unnecessary and
wrong. Please remove it.
The rest of the patch looks good.
Thanks, I don't know how could I miss it. Now it is removed.
--
Jan