On Wed, Jul 15, 2015 at 11:02:51AM +0200, Pavel Březina wrote:
On 07/14/2015 03:18 PM, Jakub Hrozek wrote:
>On Tue, Jul 14, 2015 at 02:39:13PM +0200, Pavel Březina wrote:
>>>>*Patch #02 SYSDB: Add functions to look up multiple entries including
name
>>>>and custom filter*
>>>>
>>>>>+static char *enum_filter(TALLOC_CTX *mem_ctx,
>>>>>+ const char *base_filter,
>>>>>+ const char *name_filter,
>>>>>+ const char *addtl_filter)
>>>>
>>>>You are leaking memory here if any of the allocation fails. I know it
will
>>>>be freed in the caller but it is not a good practice.
>>>
>>>As discussed on IRC, I added a context.
>>
>>Nack. You added a tmp_ctx but you still use mem_ctx :-)
>
>Let's try to again.
>
>This is the only change in the set.
Ack.
Thanks a lot for the review. I will file a ticket for the IPA support,
but that should be a separate patch atop the responder support.
* bdf32fbb3c947dd1b2c54d1c21d8028a1ddc80e6
* b9e74a747b8f1012bba3575f3e4289ef4877d64a
* 1f2fc55ecf7b5e170b2c0752304d1a2ecebc5259
* 5b2ca5cc0e22dd184e3eba84af2c00d7065c59c7
* f4e643ed7df771f83e903a6309f7ff0917819d25
* 2922461ea5357f4035a5ca7bdd84013db8767376
* fa7921c8259539b750f7e9e7bcd82aa72020826a
* fd04b25eaa5cd105da4122854d8bc1e702760e60
* cdc44abdf944b0de541fe93ecd77df4d09c856b1
* 696c17580b49d6817f1dd33915e0e209dcfe4225
* 429f8454a40b939604e9a96d780661a94a38da2e