On Tue, Aug 16, 2016 at 04:29:43PM +0200, Petr Cech wrote:
> On 08/16/2016 03:58 PM, Stephen Gallagher wrote:
>> On 08/16/2016 09:26 AM, Jakub Hrozek wrote:
>>>> On Tue, Aug 16, 2016 at 03:17:19PM +0200, Petr Cech wrote:
>>>>>>>>>> From 24d32d0eb12ddc433e64ffd6411e9e13f0067b35 Mon
Sep 17 00:00:00 2001
>>>>>>>>>> From: Petr Cech <pcech(a)redhat.com>
>>>>>>>>>> Date: Fri, 13 May 2016 05:21:07 -0400
>>>>>>>>>> Subject: [PATCH 1/5] AD_PROVIDER: Add
ad_enabled_domains option
>>>>>>>>>>
>>>>>>>>>> Resolves:
>>>>>>>>>>
https://fedorahosted.org/sssd/ticket/2828
>>>>>>>>
>>>>>>>> Did you already have the manpage hunk checked by some
native English
>>>>>>>> speaker?
>>>>>>
>>>>>> No native speaker have seen it.
>>>>
>>>> OK, can you please ask Dan or Stephen to help us word the manpage piece
>>>> better?
>>
>> Proposed man page change:
>>
>>
>>
>> ad_enabled_domains (string)
>> A comma-separated list of enabled Active Directory domains.
>> If provided, SSSD will ignore any domains not listed in this
>> option. If left unset, all domains from the AD forest will
>> be available.
>>
>> For proper operation, this option must be specified in all
>> lower-case and as the fully qualified domain name of the
>> Active Directory domain. For example:
>>
>> ad_enabled_domains =
sales.example.com,
eng.example.com
>>
>> The short domain name (also known as the NetBIOS or the flat
>> name) will be autodetected by SSSD.
>>
>> Default: Not set
>
> Thanks Stephen for review.
> Fixed patch set is attached.
>
> Regards
>
> --
> Petr^4 Čech
New issue: the tests don't build on Debian..
/libsss_test_common.a -ltevent -ltalloc -lldb -Wl,-rpath -Wl,/usr/local/lib/sssd
/usr/bin/ld: src/tests/cmocka/test_ad_subdom-test_ad_subdomains.o: undefined reference to
symbol 'idmap_error_string@(a)SSS_IDMAP_0.4'
//var/lib/jenkins/workspace/ci/label/debian_testing/ci-build-debug/.libs/libsss_idmap.so.0:
error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
Makefile:11971: recipe for target 'test_ad_subdom' failed
Hi Jakub,
thanks for notice. I fixed Makefile and CI passed:
I rebased the patch set, it is attached.
Oh and I see new mail from Lukas, I will take a look on it. :-)
Regards
--
Petr^4 Čech