Re: [SSSD] [PATCHES] LDAP: Sanitize group dn before using in filter

On 09/01/2015 11:06 AM, Lukas Slebodnik wrote: >ehlo, > >attached is alternative version for ticket 2744. >The unit test passed but there is a performance improvement. > >If we compare 3rd patch to current master than >there is a 10 less invocation of malloc (an also other functions) per group. >and we saved allocation of 1091 per group. > >There was a comment[1] in old thread about a possibility of double sanitized dn. >I was not able to find such case. I would be glad if someone >can extend unit test which will pass with master and fail with attached patch. > >LS > >[1] https://lists.fedorahosted.org/pipermail/sssd-devel/2015-August/024346.html Looks like I misunderstood your original proposal. This looks indeed better. I see now why double-sanitization is not an issue. Ack.