I am going to send a number of separate replies as I go and read about
the patches.
First on patch 01
On Wed, 15 Oct 2014 22:24:04 +0200
Jakub Hrozek <jhrozek(a)redhat.com> wrote:
Adds two new options, user and group that are specified in the
[sssd]
section. When these options are specified, SSSD will run as the user
and group. When these are not specified, SSSD will run as the
configure-time user and group.
Do we really need to specify both a user and a group ?
In other projects specifying the user and using its primary group is
considered sufficient.
I think allowing to specify both can lead to potential issues if the
user is not member of the specified group.
Unless there is an actual need to specify the group explicitly I would
simplify and allow to specify only the user.
I can't seem to find where sss_user_from_string() is defined, is it in
a previous patch not yet committed to master ?
Why do we need this function when we can call directly getpwnam() ?
Simo.
--
Simo Sorce * Red Hat, Inc * New York