On Fri, Apr 11, 2014 at 02:49:45PM +0200, Pavel Reichl wrote:
On Fri, 2014-04-11 at 12:23 +0200, Jakub Hrozek wrote:
[snip]
> > @@ -71,6 +71,7 @@ static int be_fo_get_options(struct be_ctx *ctx,
> >
DP_RES_OPT_RESOLVER_TIMEOUT);
> > opts->retry_timeout = 30;
> > opts->srv_retry_timeout = 14400;
> > + opts->srv_retry_neg_timeout = 5;
> > opts->family_order = ctx->be_res->family_order;
>
> Thank you, I've got one more question/nitpick. I wonder if 5 seconds is
> too low for a timeout..maybe 15 seconds, same as the default NSS negative
> timeout would be a better choice?
>
You're welcome. I've changed timeout to 15 seconds as you suggested. I'm
not strongly opinionated about this. If you wished I could add an option
in configure file but I suppose it's a little to much.
Yes, I don't like adding more and more options unless there is strong
demand to have a tunable.
PR
ACK to the current patch.