On Fri, 2012-03-02 at 14:16 +0100, Jakub Hrozek wrote:
Both krb5_child and ldap_child would emit a "child started"
message and
only after that set up debugging to file. This might confuse users,
because unless there is an error, the krb5_child.log might actually be
empty.
Nack. "[sssd[krb5_child[%d]]]", getpid() isn't dependent on anything
that you don't know at this point. Just talloc_asprintf() it on NULL and
then steal it onto pd later.
Also, please add NULL-checks for the talloc_asprintf() calls. If they
return NULL, just assign a static string "[sssd[ldap_child]]" or
"[sssd[krb5_child]]" without the PID.
I'm thinking we might also add a couple of "tracing" DEBUG messages so
that we can follow the flow in the subprocess more easily.
Please open an RFE.