On Fri, Dec 05, 2014 at 06:04:19PM +0200, Nikolai Kondrashov wrote:
On 12/05/2014 05:54 PM, Nikolai Kondrashov wrote:
>On 12/05/2014 11:03 AM, Jakub Hrozek wrote:
>>+# long-standing memory leak in popt
>>+{
>>+ popt-memleak-from-poptGetNextOpt-realloc
>>+ Memcheck:Leak
>>+ match-leak-kinds: definite
>
>Old versions of Valgrind (including the one in RHEL6) don't differentiate leak
>confidence and abort on encountering this field.
>
>It looks like this:
>http://sssd-ci.duckdns.org/logs/job/4/74/rhel6/ci-build-debug/auth-tests.10780.valgrind.log
>
>Please remove these.
I mean just removing these lines:
match-leak-kinds: definite
is enough.
Nick
Ah, thank you. In my defense, I didn't even get that far in my testing
as #2518 meant SSSD didn't go that far.
Thanks for the review. A new patch is attached.