-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/13/2010 09:50 AM, Stephen Gallagher wrote:
On 10/13/2010 01:42 AM, Sumit Bose wrote:
> On Tue, Oct 12, 2010 at 11:24:13AM -0400, Stephen Gallagher wrote:
> On 10/12/2010 10:18 AM, Sumit Bose wrote:
>>>> On Mon, Oct 11, 2010 at 02:32:59PM -0400, Stephen Gallagher wrote:
>>>> Also, I'm not sure that this is safe for aligned platforms like MIPS.
It
>>>> might be wisest to just make this a 32-bit value and use the alignment
>>>> code here.
>>>>
>>>>> Currently it is handled as char/uint8_t, so it shouldn't be an
issue. But
>>>>> if you prefer a uint32_t here I can change it. One other reason to
>>>>> change it would be that we always use uint32_t for such things in
the
>>>>> wire protocol. What do you think?
> Yeah, I'd prefer to remain consistent. Using a 32-bit value here gives
> us the option in the future to co-opt the high-order bits for something
> else, as well.
>> Ok, new series attached.
>> bye,
>> Sumit
Ack.
Excellent work, Sumit!
Merged one patch (SDAP_ID_OPTS had changed) and pushed to master.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAky1uXcACgkQeiVVYja6o6PMuwCeKnss8MsPKfrPTHk4lQYzj78o
qqYAmwaWgf7tttJDb5LmhAkB9r5t5vtM
=86r8
-----END PGP SIGNATURE-----