On Thu, Apr 11, 2013 at 01:47:03PM +0200, Lukas Slebodnik wrote:
On (11/04/13 11:18), Jakub Hrozek wrote:
>On Thu, Apr 11, 2013 at 11:04:06AM +0200, Lukas Slebodnik wrote:
>> I wanted to revie som patches, but test failed with unrelated issue to revieved
>> patch.
>>
>
>The test_io.c test should also call tests_set_cwd().
>
>Is this only an issue with test_io.c ? Did sysdb_tests run OK? I would
>expect them to have the same problem, can you check?
I fixed also tests_set_cwd(), there was ignored return value if TEST_DIR is empty
string. It should not happen with default TEST_DIR value.
Attached patch just fix segmentation fault and improve some lines to prevent
segfault.
Abhishek can rewrite test_io.c to using tests_set_cwd(),
(use relative paths)
Also there something what is not very good solution (transformation to relativepath)
relativepath = strchr(get_filepath(path), 't');
^^^^^
What if I decide to call ./configure --with-test-dir="temp_test"?
LS
Lukas, please send a patch that would fix the above with calling basename,
please. We need to fix this in master asap.