On Fri, Mar 20, 2015 at 04:58:38PM +0100, Pavel Reichl wrote:
> On 03/20/2015 03:26 PM, Jakub Hrozek wrote:
>> On Fri, Mar 20, 2015 at 01:13:35PM +0100, Pavel Reichl wrote:
>>>> I wonder why didn't you create a single pwexpire test instead? The
file
>>>> names are confusing, I would expect tests of authentication and acess
>>>> control.
>>> The functionality I wanted to test was in 2 separate units (ldap_auth,c,
>>> sdap_access.c), but for those units there were no tests. So I created 2 new
>>> test units (test_ldap_auth,c, test_sdap_access.c) in hope that more
>>> functions from these units will be tested. (code coverage is currently 0.0 %
>>> for both modules
(
https://jhrozek.fedorapeople.org/sssd-coverage/html/providers/ldap/index....)
>> I think this is OK as long as there's nothing specific to the expiration
>> tests in the test sources and the sources can be re-used for 'real' auth
>> and access checks.
>>
>> (btw I'm not sure how realistic is to have auth and access /unit/ tests,
>> I looked at the sources when you wrote the SSH key expiration patches,
>> but it seemed to me integration tests could be a better option)
>>
>> So I'm fine both ways.
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel(a)lists.fedorahosted.org
>>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> Please see updated patch set.
> Thanks!
>
> ci passed:
>
>
http://sssd-ci.duckdns.org/logs/job/11/31/summary.html
>
> From 4236caecdc9981d10f777e90a65aa60cd92445df Mon Sep 17 00:00:00 2001
> From: Pavel Reichl <preichl(a)redhat.com>
> Date: Fri, 6 Mar 2015 04:29:24 -0500
> Subject: [PATCH 1/3] TESTS: test expiration
Sorry, more nitpicks. I should have sent them earlier, but I didn't
notice them before.