URL:
https://github.com/SSSD/sssd/pull/463
Title: #463: cache: Check for max_id/min_id in cache_req
jhrozek commented:
"""
I have two more requests and in the interest of speeding up this PR, I also proposed
patches in my review branch:
1. There are some issues in your patch. The new error code is not handled gracefully, so
the whole lookup fails. We should, in the end, just treat the result as if the object was
not found. There were also some style errors (mixes tabs and spaces and so). Please see
this patch:
https://github.com/jhrozek/sssd/commit/1881b8dc20ec34bc1df1d3dbd9c5390e0f... and if you
agree, squash it into yours and resubmit.
2. A unit test was missing. I wrote tests for group and user lookups here:
https://github.com/jhrozek/sssd/commit/afad05ae13d5dced162eb02e0feb935821... if you
agree, please submit this patch atop yours.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/463#issuecomment-349307567