On Fri, Nov 15, 2013 at 12:22:53PM +0100, Pavel Březina wrote:
From b66343b207679cbbbdb5d4a54a7f465fbf2ec97f Mon Sep 17 00:00:00
2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
Date: Tue, 12 Nov 2013 13:52:35 +0100
Subject: [PATCH 1/3] sysdb: add sysdb_group_dn_str()
The patch doesn't apply, but more importantly there already is
sysdb_group_dn_str(), can you use that instead?
The other two patches don't apply either. I have just a couple of
comments and questions as I scrolled through them:
Patch #2 looks good to me so far, but I only read the diff.
In patch #3, I don't see the point of using tmp_ctx and stealing to "state"
later if the request is relatively short. Can you use "state" directly?
That way you guarantee that the memory will go away with the request.
btw did you test if the code works even if only some of the groups have
posix attributes set?