URL:
https://github.com/SSSD/sssd/pull/838
Title: #838: FIPS140 compliant usage of PRNG
pbrezina commented:
"""
I agree with Alexey's statements, i.e. it is not necessary to fail in cases where
security concerns are not relevant and just simple random number is needed (for example to
compute a random delay to distribute load of start up tasks etc.).
That being said, there are few minor coding style violations but otherwise I accept these
patches. And also it needs rebasing on current master.
* **Patch: util/crypto: added sss_rand()**
* there are multiple new lines around `sss_rand()` functions, only one empty line should
be there
* opening bracket should be on the first line
```c
if (expr) if (expr) {
{ ....
... }
}
```
* **Patch: crypto/libcrypto/crypto_nite.c: memory leak fixed**
* Please, do not use `if (ptr)` but rather `if (ptr == NULL)` (and vise versa for
non-null case)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/838#issuecomment-509135784