On Fri, Feb 12, 2016 at 11:33:34AM +0100, Pavel Březina wrote:
> On 01/15/2016 12:44 PM, Lukas Slebodnik wrote:
> >On (15/01/16 12:03), Pavel Březina wrote:
> >>On 01/12/2016 10:15 AM, Lukas Slebodnik wrote:
> >>>ehlo,
> >>>
> >>>The main reason for these patch was to improve
> >>>recently added logging to hbac.
> >>>
> >>>Side effect of these change is improvement for libldb
> >>>and libsemanage (6th patch)
> >>>
> >>>4th patch is not API/ABI change because
> >>>such version has not beeen released yet.
> >>>If you do not like change in hbac callback
> >>>hbac_debug_fn_t then we should also remove
> >>>because it is too internal then we should
> >>>remove also the first two arguments.
> >>>"file", "line" also leaks internal data from
libhbac.
> >>>Removing the first two arguments would be almost
> >>>consistent callbacks in libldb and libsemanage.
> >>>
> >>>LS
> >>
> >>Hi,
> >>I'm getting following errors:
> >>
> >>In file included from
/home/pbrezina/workspace/sssd/src/python/pyhbac.c:26:0:
> >>/home/pbrezina/workspace/sssd/src/providers/ipa/ipa_hbac.h:54:0: error:
> >>"SSS_ATTRIBUTE_PRINTF" redefined [-Werror]
> >>#define SSS_ATTRIBUTE_PRINTF(a1, a2) __attribute__((format(printf, a1, a2)))
> >>^
> >>In file included from
/home/pbrezina/workspace/sssd/src/python/pyhbac.c:24:0:
> >>/home/pbrezina/workspace/sssd/src/util/util.h:62:0: note: this is the
> >>location of the previous definition
> >>#define SSS_ATTRIBUTE_PRINTF(a1, a2) __attribute__ ((format (printf, a1,
> >>a2)))
> >>
> >I might add another #ifdef guard but I decided to rename macro
> >SSS_ATTRIBUTE_PRINTF -> HBAC_ATTRIBUTE_PRINTF
> >
>
> Ack.
CI:
http://sssd-ci.duckdns.org/logs/job/37/61/summary.html
Pushed to master:
* f6c1f6a561bdd5b4bba03c02988a724da3dad387
* 21274963b575262b566115008119ef836c4db211
* d833f316243f4ccd52b9b53dbd6e91c784825479
* c426a8985a009e4506bef8dac76af4fa6fc2035c
* 22bbd95a48d21452fa5bb1a96b43334503bf8132
* 2a44a8c6683cfea218ee5329bcfad953dfeb6746
It would be nice to push them also to sssd-1-13, since the patches are
low-risk and omitting them might make backporting to sssd-1-13 harder
later on, but the patches don't apply..
patches don't apply becuase hbac
debug feature is not in 1.13.
But I might prepare version without hbac debug feature.
I also realized that new line will not be printed after ldb messages.
So it might hapen that some debug messages will be on one line.
Do we want to special case it?
It's not problem with libipa_hbac becuase all debug messges there
contain new line at the end of string.
LS