5:23 a.m.
URL: https://github.com/SSSD/sssd/pull/461
Author: lslebodn
Title: #461: responder: Fix talloc hierarchy in sized_output_name
Action: opened
PR body:
"""
responder: Fix talloc hierarchy in sized_output_name
sized_output_name was a called with NULL context in
memcache_delete_entry but returned data from sized_output_name
didn't have proper talloc hierarchy and we could not release all
all returned data.
==00:01:01:29.871 10088== 934,414 bytes in 8,731 blocks are definitely lost in loss record
121 of 121
==00:01:01:29.871 10088== at 0x4C29BE3: malloc (vg_replace_malloc.c:299)
==00:01:01:29.871 10088== by 0x8FF4EAB: talloc_strdup (in
/usr/lib64/libtalloc.so.2.1.9)
==00:01:01:29.871 10088== by 0x52933B9: sss_output_name (usertools.c:808)
==00:01:01:29.871 10088== by 0x5293550: sss_output_fqname (usertools.c:863)
==00:01:01:29.871 10088== by 0x1211F9: sized_output_name (responder_common.c:1708)
==00:01:01:29.871 10088== by 0x1137E6: memcache_delete_entry (nss_get_object.c:112)
==00:01:01:29.871 10088== by 0x113BB6: nss_get_object_done (nss_get_object.c:245)
==00:01:01:29.871 10088== by 0x8DE5291: _tevent_req_error (in
/usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x1276CE: cache_req_done (cache_req.c:1047)
==00:01:01:29.871 10088== by 0x8DE5291: _tevent_req_error (in
/usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x126AF6: cache_req_search_domains_done
(cache_req.c:607)
==00:01:01:29.871 10088== by 0x8DE4AB9: tevent_common_loop_immediate (in
/usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x8DE9C9C: ??? (in /usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x8DE82A6: ??? (in /usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x8DE40CC: _tevent_loop_once (in
/usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x8DE42FA: tevent_common_loop_wait (in
/usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x8DE8246: ??? (in /usr/lib64/libtevent.so.0.9.31)
==00:01:01:29.871 10088== by 0x5291B32: server_loop (server.c:718)
==00:01:01:29.871 10088== by 0x11004C: main (nsssrv.c:560)
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/461/head:pr461
git checkout pr461
6:43 a.m.
New subject: [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Title: #461: responder: Fix talloc hierarchy in sized_output_name
fidencio commented:
"""
Ack! I'll add the accepted label after getting the results from our CI.
"""
See the full comment at https://github.com/SSSD/sssd/pull/461#issuecomment-347849459
8:20 a.m.
New subject: [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Title: #461: responder: Fix talloc hierarchy in sized_output_name
fidencio commented:
"""
I can see one failure in our internal CI:
```
ERROR: Command failed:
# /usr/bin/systemd-nspawn -q -M 5b05f2b1276141ae922d65eae7807749 -D
/var/lib/mock/fedora-27-x86_64/root -a --private-network --setenv=TERM=vt100
--setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock
--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf
"\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$
--setenv=LANG=en_US.UTF-8 -u mockbuild bash --login -c /usr/bin/rpmbuild -bb --target
x86_64 --nodeps /builddir/build/SPECS/sssd.spec
```
This failure happened on f27 system but is not related to this patch at all. For all other
systems, CI passed: http://vm-031.${abc}/logs/job/81/98/summary.html
"""
See the full comment at https://github.com/SSSD/sssd/pull/461#issuecomment-347873986
8:21 a.m.
New subject: [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Title: #461: responder: Fix talloc hierarchy in sized_output_name
fidencio commented:
"""
I'm adding the "Accepted" label. Thanks for the patch and for the
explanation of the issue (face-to-face, last week). I totally missed that when looking at
the issue.
"""
See the full comment at https://github.com/SSSD/sssd/pull/461#issuecomment-347874199
8:21 a.m.
New subject: [sssd PR#461][+Accepted] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Title: #461: responder: Fix talloc hierarchy in sized_output_name
Label: +Accepted
7:44 a.m.
New subject: [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Title: #461: responder: Fix talloc hierarchy in sized_output_name
lslebodn commented:
"""
On (29/11/17 14:20), fidencio wrote:
I can see one failure in our internal CI:
```
ERROR: Command failed:
# /usr/bin/systemd-nspawn -q -M 5b05f2b1276141ae922d65eae7807749 -D
/var/lib/mock/fedora-27-x86_64/root -a --private-network --setenv=TERM=vt100
--setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock
--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf
"\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$
--setenv=LANG=en_US.UTF-8 -u mockbuild bash --login -c /usr/bin/rpmbuild -bb --target
x86_64 --nodeps /builddir/build/SPECS/sssd.spec
```
This failure happened on f27 system but is not related to this patch at all. For all other
systems, CI passed: http://vm-031.${abc}/logs/job/81/98/summary.html
That is just not ideal report from mock. But build log shows
it was a known unit test failure.
```
FAIL: find_uid-tests
====================
Running suite(s): find_uid
(Wed Nov 29 14:34:21:085901 2017) [sssd] [get_uid_from_pid] (0x0020): read failed [3][No
such process].
(Wed Nov 29 14:34:21:086019 2017) [sssd] [get_active_uid_linux] (0x0020): get_uid_from_pid
failed.
66%: Checks: 3, Failures: 1, Errors: 0
src/tests/find_uid-tests.c:78:F:find_uid:test_get_uid_table:0: get_uid_table failed.
FAIL find_uid-tests (exit status: 1)
```
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/461#issuecomment-348191570
8:55 a.m.
New subject: [sssd PR#461][comment] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Title: #461: responder: Fix talloc hierarchy in sized_output_name
lslebodn commented:
"""
master:
* 051e0fc7cc86fb4e4b3a9323a61684ad3a6fa589
* 06e741a9bf23a18a998f366d9a8990b887a01638
"""
See the full comment at https://github.com/SSSD/sssd/pull/461#issuecomment-348211600
8:55 a.m.
New subject: [sssd PR#461][closed] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Author: lslebodn
Title: #461: responder: Fix talloc hierarchy in sized_output_name
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/461/head:pr461
git checkout pr461
8:55 a.m.
New subject: [sssd PR#461][+Pushed] responder: Fix talloc hierarchy in sized_output_name
URL: https://github.com/SSSD/sssd/pull/461
Title: #461: responder: Fix talloc hierarchy in sized_output_name
Label: +Pushed
2354
days inactive
2356
days old
sssd-devel@lists.fedorahosted.org
8 comments
2 participants
participants (2)
-
fidencio -
lslebodn