https://bugzilla.redhat.com/show_bug.cgi?id=1927907
Bug ID: 1927907 Summary: Latest release sssd 2.4.1 hard requires Python 3 Product: Fedora Version: 34 Status: NEW Component: sssd Assignee: sssd-maintainers@lists.fedoraproject.org Reporter: jlebon@redhat.com QA Contact: extras-qa@fedoraproject.org CC: abokovoy@redhat.com, atikhono@redhat.com, jhrozek@redhat.com, lslebodn@redhat.com, mzidek@redhat.com, pbrezina@redhat.com, rharwood@redhat.com, sbose@redhat.com, ssorce@redhat.com, sssd-maintainers@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Description of problem:
It seems since the 2.4.1 rebase (https://src.fedoraproject.org/rpms/sssd/c/9e5dd4b66572aeb348f3cc854ce7fca9f7...), sssd now pulls in python3 because it changed python3-sssdconfig from a "Suggests" to a "Requires". In Fedora CoreOS, we're trying to avoid shipping Python entirely to encourage containerizing user workloads and to keep the OS minimal. In a rawhide and f34 build, this package was identified as pulling it back in.
Would it be possible to make it a weak dep again? This would also be useful in other environments like containers and custom OS builds which value minimalism. We can help with that if there's agreement.
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
Alexey Tikhonov atikhono@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jlebon@redhat.com | |) | |needinfo?(pbrezina@redhat.c | |om) | |needinfo?(sbose@redhat.com)
--- Comment #1 from Alexey Tikhonov atikhono@redhat.com --- Hi Jonathan,
do I understand correctly that you are fine with ``` %package tools ... Requires: python3-sssdconfig = %{version}-%{release} ``` that was in the spec file even before this rebase (i.e. you do not pull sssd-tools in Fedora CoreOS)?
Change you mention was introduced upstream in https://github.com/SSSD/sssd/commit/5eb4d5c8e02c4c2ed32bee7269cf681b68613ed9 , so this is basically what RHEL was using. And it's been there about 7 years, so probably nobody remembers the reason anymore.
In general this bz is a regression of bz 1667444
So I think we can fix it back to 'Suggests' at least conditionally for Fedora, but in general I don't see a reason to hard require in on RHEL as well. Sumit, Pavel, what would you say?
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
Sumit Bose sbose@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sbose@redhat.com) |
--- Comment #2 from Sumit Bose sbose@redhat.com --- Hi,
please note the 'sssd' package is a meta package which just pulls in other packages. E.g. sub-packages like e.g. sssd-ad for Active Directory integration are listed in 'Requires:' as well. Is this kind of integration expected for Fedora CoreOS? If not it might be more suitable to not include the 'sssd' package but only 'sssd-common' and 'sssd-kcm' as it is in the Fedora minimal installation.
Nevertheless I think it is ok to change 'Requires' to 'Suggests' for 'python3-sssdconfig'.
bye, Sumit
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
--- Comment #3 from Alexey Tikhonov atikhono@redhat.com --- (In reply to Sumit Bose from comment #2)
Hi,
please note the 'sssd' package is a meta package which just pulls in other packages. E.g. sub-packages like e.g. sssd-ad for Active Directory integration are listed in 'Requires:' as well. Is this kind of integration expected for Fedora CoreOS? If not it might be more suitable to not include the 'sssd' package but only 'sssd-common' and 'sssd-kcm' as it is in the Fedora minimal installation.
Yes, it was discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1667444#c1 already... I agree it makes sense for CoreOS team to review their approach here...
Nevertheless I think it is ok to change 'Requires' to 'Suggests' for 'python3-sssdconfig'.
Ok, thanks. JFTR: I read this as "and on RHEL as well".
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
--- Comment #4 from Alexey Tikhonov atikhono@redhat.com --- Upstream PR: https://github.com/SSSD/sssd/pull/5500
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
--- Comment #5 from Lukas Slebodnik lslebodn@redhat.com ---
And it's been there about 7 years, so probably nobody remembers the reason anymore.
python3-sssdconfig was never required on rhel7 because it has never been there. python-sssdconfig was required because of authonfig did not want to require it due to "optional" dependency on python-sssdconfig but it was required for proper functionality of authconfig for sssd
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
--- Comment #6 from Alexey Tikhonov atikhono@redhat.com --- (In reply to Lukas Slebodnik from comment #5)
And it's been there about 7 years, so probably nobody remembers the reason anymore.
python3-sssdconfig was never required on rhel7 because it has never been there. python-sssdconfig was required because of authonfig did not want to require it due to "optional" dependency on python-sssdconfig but it was required for proper functionality of authconfig for sssd
Yes, I meant 'python-sssdconfig' and just cut it short.
Thank you for the explanation.
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
Jonathan Lebon jlebon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jlebon@redhat.com | |) |
--- Comment #7 from Jonathan Lebon jlebon@redhat.com ---
please note the 'sssd' package is a meta package which just pulls in other packages. E.g. sub-packages like e.g. sssd-ad for Active Directory integration are listed in 'Requires:' as well. Is this kind of integration expected for Fedora CoreOS? If not it might be more suitable to not include the 'sssd' package but only 'sssd-common' and 'sssd-kcm' as it is in the Fedora minimal installation.
Thanks, I think that makes sense as well. I don't think we can remove all the sssd packages we've been shipping so far, but at least we can freeze on the set we're currently shipping.
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
Pavel Březina pbrezina@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #9 from Pavel Březina pbrezina@redhat.com --- Pushed PR: https://github.com/SSSD/sssd/pull/5500
* `master` * b1f4dc82a5f9d30121f641430c9cbbb804686974 - SPEC: don't hard require python3-sssdconfig in a meta package
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
Alexey Tikhonov atikhono@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED Fixed In Version| |sssd-2.4.2-2.fc34
https://bugzilla.redhat.com/show_bug.cgi?id=1927907
Alexey Tikhonov atikhono@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|MODIFIED |CLOSED Last Closed| |2022-03-14 16:51:06
sssd-maintainers@lists.fedoraproject.org