Re: [vdsm] Change in vdsm[master]: tests: fix gluster storage exception test
* danken(a)redhat.com <danken(a)redhat.com> [2012-05-29 09:29]:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix gluster storage exception test
......................................................................
Patch Set 1: Looks good to me, approved
Thanks Ryan. Though Python has the lovely
4100 <= obj.code <= 4800
Thanks, but I'm well aware of the python syntax.
I've been requested in the past[1] to be more verbose in the asserts so I
figured I'd break it out into to separate asserts. Is there a general
guideline we're to follow when it comes to the test cases? I'd be happy
to follow.
1. http://gerrit.ovirt.org/#patch,unified,4323,3,tests/netinfoTests.py
syntax.
--
To view, visit http://gerrit.ovirt.org/4822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a4ac90cff064def5eeac30cbdab664c88b5253
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com