Federico Simoncelli has posted comments on this change.
Change subject: Explicitly close libvirt connections at exist
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/17192/3/lib/vdsm/libvirtconnection.py
File lib/vdsm/libvirtconnection.py:
Line 176: def __close_connections():
Line 177: for conn in __connections.values():
Line 178: conn.close()
Line 179:
Line 180: atexit.register(__close_connections)
could be confusing.. don't you prefer something more tight to vdsm, and not
+1 for prepareForShutdown (that in theory should already call stop_event_loop for cleanness).
--
To view, visit
http://gerrit.ovirt.org/17192
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b15f3ab017828a63960ba9311fa2bf6bfab4729
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
asegurap@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Itamar Heim
iheim@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: mooli tayer
mtayer@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes