Yeela Kaplan has posted comments on this change.
Change subject: utils: replace import for persist/unpersist ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47829/1/lib/vdsm/utils.py File lib/vdsm/utils.py:
Line 63: persist = Config().persist Line 64: unpersist = Config().unpersist Line 65: except ImportError: Line 66: try: Line 67: # If failing to import old code, then try importing the legacy code
Please remind me: why do we still need this import at all?
There is the comment that explains it '# If failing to import old code, then try importing the legacy code'.
At the time we had to support legacy code of ovirt node. Fabian should know if we can remove this section now. Line 68: from ovirtnode import ovirtfunctions Line 69: persist = ovirtfunctions.ovirt_store_config Line 70: unpersist = ovirtfunctions.remove_config Line 71: except ImportError: