Nir Soffer has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk. ......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45077/8/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2634: Line 2635: # Find and remove disk device from vm's conf Line 2636: for dev in self.conf['devices'][:]: Line 2637: if (dev['type'] == hwclass.DISK and Line 2638: dev['path'] == drive.path): Please fix pep8 error:
$ pep8 vdsm/virt/vm.py vdsm/virt/vm.py:2638:29: E127 continuation line over-indented for visual indent
You should run make check locally before posting patches to gerrit. Line 2639: with self._confLock: Line 2640: self.conf['devices'].remove(dev) Line 2641: break Line 2642: