Dan Kenigsberg has posted comments on this change.
Change subject: tests: do not check permissions on dos filesystem ......................................................................
Patch Set 1:
(2 comments)
.................................................... Commit Message Line 11: the permissions of the files in the created filesystem. Line 12: Line 13: This is fine for filesystems which support permissions, Line 14: but DOSFS/FAT/VFAT does not, then the tests on this Line 15: filesystem started to fail for no good reasons. How come test_mkFloppyFs has ever passed verification? Line 16: Line 17: This patch fixes this misbehaviour by disabling the Line 18: permissions check in filesystem which do not support Line 19: them.
.................................................... File tests/mkimageTests.py Line 102: for perm, expected in permsMask: Line 103: self.assertEqual(bool(data.st_mode & perm), expected, Line 104: '%s: %s' % (filepath, oct(data.st_mode))) Line 105: Line 106: def _check_content(self, checkPerms=True): It's a bad practice to have a function with two functionalities. However breaking it into three ( iterate files, check a file content, and check a file permission) seems a bit excessive. Do you have a better idea? Line 107: """ Line 108: Ensure that the workdir contains what we want Line 109: """ Line 110: out_dir = os.listdir(self.workdir)